Skip to content

Add initial support for Visual Studio 2026 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add initial support for Visual Studio 2026 #17

wants to merge 2 commits into from

Conversation

@jamesobutler
Copy link
Collaborator

@jamesobutler jamesobutler commented Sep 23, 2025 •
edited
Loading

See https://devblogs.microsoft.com/visualstudio/visual-studio-2026-insiders-is-here/

https://devblogs.microsoft.com/cppblog/c-language-updates-in-msvc-build-tools-v14-50/

Visual Studio 2026 in GitHub hosted runners progress at https://github.com/actions/runner-images/issues/13035

@jamesobutler jamesobutler requested a review from jcfr September 23, 2025 13:55
@jamesobutler jamesobutler mentioned this pull request Sep 23, 2025
Open
@jcfr
Copy link
Contributor

jcfr commented Sep 23, 2025

To help understand the failures:

@jamesobutler
Copy link
Collaborator Author

jamesobutler commented Sep 23, 2025 •
edited
Loading

Testing: https://github.com/scikit-build/cmake-FindVcvars/actions/runs/17952851801/job/51056618203?pr=17

1: CMake Error at D:/a/cmake-FindVcvars/cmake-FindVcvars/src/FindVcvars.cmake:391 (cmake_host_system_information):
1: cmake_host_system_information does not recognize VS_18_DIR

VS_18_DIR is available in CMake as of this commit. It will be available in CMake 4.2.0 estimated Oct 1st release (https://gitlab.kitware.com/cmake/cmake/-/milestones/177#tab-issues). GitHub Action jwlawson/actions-setup-cmake doesn't appear to support pulling nightly builds of CMake, so will need to wait for the 4.2.0 release.

@jcfr jcfr force-pushed the visual-studio-2026 branch 2 times, most recently from 35e4c77 to 0839c8b Compare September 23, 2025 22:28
@jamesobutler jamesobutler force-pushed the visual-studio-2026 branch 2 times, most recently from c698312 to 2d6e2f3 Compare October 27, 2025 19:39
@jamesobutler
CI: Switch CMake setup action to lukka/get-cmake
12f9d5a 
https://github.com/lukka/get-cmake has support for CMake pre-releases which https://github.com/jwlawson/actions-setup-cmake does not support. It also appears that get-cmake action is actively maintained while actions-setup-cmake has not had an update in ~1.5 years.
@jamesobutler
Copy link
Collaborator Author

jamesobutler commented Oct 27, 2025 •
edited
Loading

I have been able to bypass the limitation of jwlawson/actions-setup-cmake not supporting CMake pre-releases by switching to lukka/get-cmake. It also appears that get-cmake action is actively maintained while actions-setup-cmake has not had an update in ~1.5 years. get-cmake also currently has 120 stars on GitHub compared to actions-setup-cmake having 75 stars if that is any indication of the popularity and support of the project.

@jcfr This has allowed for CI to proceed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcfr jcfr Awaiting requested review from jcfr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamesobutler @jcfr